Skip to content

Cleanup of unused imports and variables#17

Closed
jurgenwigg wants to merge 1 commit intonocomplexity:mainfrom
jurgenwigg:cleanup
Closed

Cleanup of unused imports and variables#17
jurgenwigg wants to merge 1 commit intonocomplexity:mainfrom
jurgenwigg:cleanup

Conversation

@jurgenwigg
Copy link
Copy Markdown
Contributor

I've executed autoflake to remove unused things and make code cleaner.

@nocomplexity
Copy link
Copy Markdown
Owner

Thank you for taking the time to submit this PR — it’s much appreciated!

Unfortunately, I won’t be able to merge it as it stands. The main reasons are:

  • Some imports are intentionally included for their side effects, so removing them changes behaviour.
  • Applying these changes across the codebase would introduce a number of unintended side effects, which would require significant effort to resolve.

In general, autoflake can be helpful for very simple clean-ups. However, it isn’t perfect and can miss important context-specific details, particularly in a larger codebase like this.

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants