feat: implement inbound roaming reject - #303
Conversation
osmith42
left a comment
osmith42
left a comment
There was a problem hiding this comment.
LGTM besides the typo and some ideas, thanks for making this!
Implements inbound roaming reject cause configuration. This is useful for private networks and public SIMs from other carriers try to join. In that case, you want to respond with ROAMING_NOT_ALLOWED as reject cause in 2G/3G/4G. Otherwise, the UE may believe that its subscription is terminated. Defaults to ROAMING_NOT_ALLOWED for a safe OOBE. Production carriers are advised to change this to IMSI_UNKNOWN.
"Whether or not to a subscriber" -> "Whether or not to allow a subscriber" Co-Authored-By: Qwen 3.6 27B MTP (speculative) <noreply@pi.dev> Generated-By: pi 0.82.1
dc2cc56 to
80e89bd
Compare
|
I've addressed your feedback @osmith42. I've also rebased the branch on the current master as on my Fedora 44 machine I had issues getting this to run due to the branch being incompatible to 3.14, so I needed the changes from #321 to test. In addition, I've also changed the behavior in be9f0cc: If the value is not configured, resort to the old default. That seems the safest option, also a small typo was fixed in ecbe0a5 that got unnoticed during the review. AI disclosure: I am currently experimenting with open weight LLMs on my own GPU (next to me under a desk, not hosted) and made that transparent with Oh and: The comments on the PR are written by me not an LLM. You are still talking to a human 😉 |
osmith42
left a comment
osmith42
left a comment
There was a problem hiding this comment.
LGTM! I'd slightly tweak the changelog entry as mentioned, otherwise it is good to go in my opinion. If you agree, feel free to make the change and then merge it directly.
Add validate_config() to reject invalid reject_unknown_imsis_with values, preventing silent misconfiguration from typos. Co-Authored-By: Qwen 3.6 27B MTP (speculative) <noreply@pi.dev> Generated-By: pi 0.82.1
Use .get() with default instead of direct dict access so the config option is optional. Co-Authored-By: Qwen 3.6 27B MTP (speculative) <noreply@pi.dev> Generated-By: pi 0.82.1
Co-Authored-By: Qwen 3.6 35B A3B Q5 <noreply@pi.dev> Generated-By: pi 0.82.1
80e89bd to
adc35e0
Compare
2 participants
Implements inbound roaming reject cause configuration. This is useful for private networks and public SIMs from other carriers try to join.
In that case, you want to respond with ROAMING_NOT_ALLOWED as reject cause in 2G/3G/4G. Otherwise, the UE may believe that its subscription is terminated.
Defaults to ROAMING_NOT_ALLOWED for a safe OOBE. Production carriers are advised to change this to IMSI_UNKNOWN.