chore: Cleanup setAppTypes and move it to AppManager#59493
Merged
CarlSchwan merged 2 commits intomasterfrom Apr 12, 2026
Merged
chore: Cleanup setAppTypes and move it to AppManager#59493CarlSchwan merged 2 commits intomasterfrom
CarlSchwan merged 2 commits intomasterfrom
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
CarlSchwan
approved these changes
Apr 10, 2026
joshtrichards
approved these changes
Apr 12, 2026
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
I guess the swap away from AppManager is necessary and reasonable for the Installer class in this case (and since there don't seem to be any other consumers for setAppTypes at present).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move this internal method to AppManager, take the opportunity to clean it up.
Checklist
3. to review, feature component)stable32)AI (if applicable)