Repository navigation
test(cypress): find the pdf viewer frame in the new viewer markup - #6186
Merged
Merged
Conversation
juliusknorr
marked this pull request as ready for review
October 12, 2026 12:47
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
test/cypress-pdfviewer-markup
branch
from
October 12, 2026 20:04
894da42 to
bdfa251
Compare
elzody
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Open PDF with files PDF viewer" still looked for
.viewer__file-wrapper, which only the old viewer app rendered. With nextcloud/files_pdfviewer#1586 the PDF opens in the new viewer, so the test now finds the pdf.js frame through[data-handler="pdf"]on the viewer modal.TODO
cypress-e2e.ymlback tomatrix.server-versionsonce feat(viewer): register the pdf handler with @nextcloud/viewer聽files_pdfviewer#1586 is mergedChecklist