Repository navigation
Conversation
elzody
marked this pull request as ready for review
October 8, 2026 21:15
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5[1m]
elzody
force-pushed
the
feat/upgrade-eslint
branch
from
October 9, 2026 15:23
63a3899 to
567c334
Compare
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5[1m]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On my setup,
npm run lintwas broken because our ESLint 8.57 config walks up the directory tree and finds server'seslint.config.jsand switches to flat config mode. This causes ESLint to reject the--extoption. The current format is also end-of-life, and we needed to upgrade anyway to avoid long-standing dependabot conflicts and to use the new Vue 3 rules now that the migration has been completed in #6142.The three commits in this PR do the following:
npm run lint:fixto automatically resolve any fixable violationsSeveral things were carried over from the old config like the JSDoc rules. but some new ones were added to account for new rules that help avoid too much churn for what was supposed to be a targeted migration. They can be followed up in separate PRs eventually.
The lock file diff is huge but that's because it migrated from v2 to v3 (matching other Nextcloud apps) and it also includes a bunch of small version bumps, but they are reasonable.
The failing test at the moment is due to a pre-existing issue with the files_pdfviewer app and is not related to these changes.
If it wasn't clear already, this PR is AI-assisted (Claude Opus 5).
Checklist