Repository navigation
Conversation
When trying to upload a global template that failed (e.g. file was too large), it would try to detect the MIME type of the file even if it didn't exist, causing a 500 Internal Server Error response. Instead, we should check for errors first, and then try to detect the MIME type only after we know there are no errors. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Distinguish between an upload that failed and an upload that simply contained nothing Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
elzody
force-pushed
the
fix/global-template-upload
branch
from
October 9, 2026 17:52
b9458a7 to
adb16f6
Compare
elzody
marked this pull request as ready for review
October 9, 2026 18:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When trying to upload a global template that failed (e.g. file was too large), it would try to detect the MIME type of the file even if it didn't exist, causing a 500 Internal Server Error response. Instead, we should check for errors first, and then try to detect the MIME type only after we know there are no errors.
Assisted-by: ClaudeCode:claude-opus-5
Checklist