Repository navigation
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Productivity team
fc82d0a to
f24d64f
Compare
|
@juliusknorr Do you think we should ignore the remote font config warning for now? Didn't we discuss that, because we can have these configuration files of our own now, we can always ensure there is one? |
|
Curently we cannot verify this anyways as it is a setting in coolwsd.xml and we cannot check that. Mid-term collabora planned to remove this configuration option as far as I understood and pass over the fonts without any configuration required, so I'd say it is fine to ignore that, yes. |
f24d64f to
6c9d5ad
Compare
|
@nextcloud/designers I have uploaded a screen recording, can I get a design review on this please? :) |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
I'd say generally it's fine, but instead of the red trash button, a tertiary one (icon only) is enough?
Also @marcoambrosini @susnux what would be cool is a nice component for lists so this is consistent across Nextcloud. If we want to get fancy, this could be a grid/tiled view with font and font name below each other, sort of laid out like the tiles we use for the settings of Dashboard.
| --> | ||
|
|
||
| <template> | ||
| <NcSettingsSection :name="t('richdocuments', 'Custom Fonts')" |
There was a problem hiding this comment.
| <NcSettingsSection :name="t('richdocuments', 'Custom Fonts')" | |
| <NcSettingsSection :name="t('richdocuments', 'Custom fonts')" |
Detail: Should be sentence case, like below for "Available fonts"
| data-cy="newFontInput" | ||
| @change="selectFile"> | ||
|
|
||
| <table> |
There was a problem hiding this comment.
I would not use a table for this, generally tables are bad for a11y and especially in this case where you do not have a table header.
Instead it probably makes more sense to use a list for this, semantically, and style it like you want.
There was a problem hiding this comment.
Thanks for the feedback, I really appreciate any a11y tips I can get!
We already have |
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Move the remote font config hint and the documentation link into CustomFonts.vue, drop the font code left behind in AdminSettings.vue, and remove the now unused SettingsFont, SettingsFontList and SettingsInputFile components. Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Browsers report an empty type for some valid font files, notably .ttf. Restore the guard that skips the mimetype check in that case. Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
The selector was missing its closing bracket. Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
REUSE.toml annotates cypress/fixtures/** as AGPL-3.0-or-later, which mislabels the bundled Amatic SC font. Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
6c9d5ad to
507120c
Compare
This branch has not been deployed
4 participants
Summary
Introduces Pinia in an effort to organize the admin settings a bit instead of having everything in one massive component.
Screen Recording
Custom Fonts
admin-settongs-redesign-custom-fonts.mp4
TODO
Checklist