Repository navigation
fix(ui): select the matching sender for replies - #13802
Open
LorenzLoesch wants to merge 1 commit into
Open
LorenzLoesch wants to merge 1 commit into
LorenzLoesch wants to merge 1 commit into
Conversation
LorenzLoesch
marked this pull request as ready for review
October 4, 2026 14:38
LorenzLoesch
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
October 4, 2026 14:38
kesselb
reviewed
Oct 5, 2026
| <NcFormBoxSwitch | ||
| :model-value="replyFromMatchingAddress" | ||
| :label="t('mail', 'Automatically select the sender address for replies')" | ||
| :description="t('mail', 'Use the account or alias involved in the message')" |
Contributor
There was a problem hiding this comment.
@kra-mo can we make it the default without a option to change? It sound reasonable to me to automatically pick the recipient as alias (if defined).
Member
There was a problem hiding this comment.
Yeah, people can always manually change it on a case-by-case basis if needed.
Author
There was a problem hiding this comment.
sure, do you want me to change it that way?
i modelled the feature after gmail, where you can change it in the settings. but i agree that this is not necessary.
Member
Author
There was a problem hiding this comment.
i think the pr is in good shape now. let me know if anything else needs to change.
LorenzLoesch
force-pushed
the
fix/reply-sender-identity
branch
2 times, most recently
from
October 6, 2026 14:24
bb2e045 to
714cbfe
Compare
Replies to alias-addressed mail defaulted to the account primary, which changed the sending identity in an existing conversation. Match the clicked message against configured accounts and aliases; the composer provides a per-message override. Preserve outgoing recipients independently of the selected identity and clear the old alias when choosing a primary address. Identity inference is limited to the clicked message. New messages, forwards, and restored drafts retain their existing identity handling. Signed-off-by: Lorenz Loesch <lorenz.loesch@gmail.com>
LorenzLoesch
force-pushed
the
fix/reply-sender-identity
branch
from
October 8, 2026 13:49
31da7da to
55fbb2e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replies to mail received through an alias currently default to the account's primary address. Automatically select the configured account or alias involved in the clicked message, including identities on other connected accounts. Users can override the From address in the composer for each message.
Fixes #6236. Related: #607 and #10559 (closed duplicate of #6236).
Validation:
composer test:unit -- --no-coverage). The suite emits three existing discovery warnings for missing S/MIME chain-key fixtures.AI assistance: Implementation and local reviews were assisted by Codex (GPT-6).