Repository navigation
fix: use pdf viewer instead of office - #13685
Merged
Merged
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
added
blocked
bug
2. developing
AI assisted
Contributor
|
Good approach 馃憤 Should work without #13662? |
Contributor
Author
Not on 36, I'm working on a pr now |
Contributor
|
The approach works on 35. files_pdfviewer enabled: Viewer is shown when clicking on the attachment This is already better then opening Collabora or Eurooffice with a never-ending loading animation ;) If there's a demand, we can look into generating a signed link so clients without a session can fetch the attachment, but for now I'd say we merge and look into the adjustments for 36 later? |
hamza221
marked this pull request as ready for review
October 8, 2026 14:20
hamza221
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
October 8, 2026 14:20
kesselb
approved these changes
Oct 8, 2026
Contributor
|
/backport to stable5.13 please |
Contributor
|
/backport to stable5.12 please |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #13662
Fix #12988
Fix #13261
Fix Euro-Office/eurooffice-nextcloud#104
馃 AI (if applicable)