Repository navigation
fix(notification): throw UnknownNotificationException for unknown notifications - #146
Conversation
…ifications Manager::prepare() skips notifiers silently when they throw UnknownNotificationException, but logs a deprecation warning for a plain InvalidArgumentException. Both Notifier::prepare() paths (foreign app and unknown subject) now throw the dedicated exception. Assisted-by: opencode:deepseek/deepseek-v4.1-flash Signed-off-by: Jonas Zürcher <mail@jonaszuercher.ch>
|
Thank you @tsueri |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Manager::prepare() skips notifiers silently when they throw UnknownNotificationException, but logs a deprecation warning for a plain InvalidArgumentException. Both Notifier::prepare() paths (foreign app and unknown subject) now throw the dedicated exception.
Assisted-by: opencode:deepseek/deepseek-v4.1-flash
Signed-off-by: Jonas Zürcher