Repository navigation
Leave the template's Apple team out of generated iOS apps - #174
Merged
Merged
Conversation
A generated iOS project kept the template's DEVELOPMENT_TEAM, and with the
templates' SAMPLE_CODE_DISAMBIGUATOR = ${DEVELOPMENT_TEAM} the team also ended
its Debug bundle ID. The iOS worker now clears it (Xcode asks for the
developer's own team on the first device build; simulator builds need none),
and the README says to set your team and the API's app_links for the invitation
link. Fixes #173.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #173.
DEVELOPMENT_TEAMin the generatedproject.pbxproj(clearPbxprojTeam/clearIosTeam, after the version reset). With the templates'SAMPLE_CODE_DISAMBIGUATOR = ${DEVELOPMENT_TEAM}, the team also ended the Debug bundle ID; now it doesn't.app_links(<Team ID>.<bundle ID>) for the paid template's invitation link.Test plan
npm run ci: 209 tests pass; the new test fails without the module and with a regex that misses a quoted team--domain=barberq.app), with its team cleared by the new function:xcodebuild buildfor the iPhone 17 Pro simulator succeeds; the bundle ID isapp.barberq.BarberQ.ios🤖 Generated with Claude Code
https://claude.ai/code/session_018iXcEetCio5kwB6Fhf2EJi