Repository navigation
test: ignore Stage 2 device overrides from the developer's shell - #166
Merged
Merged
Conversation
With NATIVEAPPTEMPLATE_MOBILE_IOS_DEVICE / _ANDROID_DEVICE exported (as when pointing Stage 2 at a specific simulator), selectDevice resolved the override against the fake mobile-mcp device lists and six smoke tests failed, including in prepublishOnly. Clear both at the top of the suite; the override tests set their own values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTy8UZA6Rq4Pw6Ww8WotGv
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/smoke.test.tsclearsNATIVEAPPTEMPLATE_MOBILE_IOS_DEVICEandNATIVEAPPTEMPLATE_MOBILE_ANDROID_DEVICEat the top of the suite (in the test process only). Tests that exercise the override already set their own value.Why
With either variable exported in the shell (e.g. to point Stage 2 at a particular simulator),
selectDeviceresolved it against the fake mobile-mcp device lists and 6 smoke tests failed — theselectDevicetests and therunStage2Visual/ Stage 2 tests that go through it. BecauseprepublishOnlyrunsnpm run ci, this also blockednpm publishfrom such a shell (hit while releasing 0.4.1).Test
npm run ciwith both overrides set: 201/201 (was 195/201)npm testwith neither set: 201/201🤖 Generated with Claude Code
https://claude.ai/code/session_01GTy8UZA6Rq4Pw6Ww8WotGv