[ISSUE #9178]🐛Fix macOS mapped-file retirement build - #9179
Conversation
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe unsupported mapped-file retirement backend now implements ChangesMapped-file retirement backend
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Which Issue(s) This PR Fixes(Closes)
Brief Description
Add the missing
NamespaceRoot::open_active_segmentimplementation to the unsupported mapped-file retirement backend used on macOS and other non-Linux/non-Windows targets. The method preserves the existing safe behavior by returningNamespaceVerificationError::Unsupported.Add a supported-host compile-time function-signature contract for the unsupported backend so regular test and Clippy builds detect future backend interface drift.
How Did You Test This Change?
cargo fmt --all -- --check: passed.cargo check -p rocketmq-store-local --tests --all-features: passed.cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings: passed.cargo +nightly-2026-07-05 check --locked --all-targets --all-featuresfromfuzz/: passed.git diff --check: passed.x86_64-apple-darwincross-check was attempted from Linux but could not compile native C dependencies because a macOS C cross-compiler was unavailable; the pull request CI provides the native macOS build verification.Summary by CodeRabbit
Bug Fixes
Tests