Skip to content

Fix docks becoming "pencil thin" on close and reopen [Port to main]#63

Merged
mathesoncalum merged 1 commit into
musescore:mainfrom
mathesoncalum:pencil_thin_docks
Jun 2, 2026
Merged

Fix docks becoming "pencil thin" on close and reopen [Port to main]#63
mathesoncalum merged 1 commit into
musescore:mainfrom
mathesoncalum:pencil_thin_docks

Conversation

@mathesoncalum

@mathesoncalum mathesoncalum commented May 28, 2026

Copy link
Copy Markdown
Contributor

Ports the framework part of musescore/MuseScore#33402

Build configuration

musescore: musescore/MuseScore/main
musescore platforms: linux_x64 linux_arm64 macos windows_x64 windows_portable

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request refines the dock window system's lifecycle management across three components. The QML loader for dock panels now requires both visibility and an initialization flag before activating, ensuring proper initialization sequencing. The C++ page deinitialization now explicitly calls cleanup on each dock before disconnecting. Additionally, macOS-specific widget sizing logic was refactored to always update the quick item size instead of returning early, providing consistent behavior with or without a floating window.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing the required template sections including CLA acknowledgment, title verification, commit message documentation, testing confirmation, and coding standards compliance checklist. Fill out all required checklist items from the template: CLA signature, title verification, commit message details, reviewability, coding standards, unnecessary changes check, compilation verification, and unit test confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main problem being fixed: docks becoming 'pencil thin' on close and reopen, and clearly indicates this is a port to main branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mathesoncalum

Copy link
Copy Markdown
Contributor Author

/build

@github-actions

Copy link
Copy Markdown

@mathesoncalum

Copy link
Copy Markdown
Contributor Author

/build

@github-actions

Copy link
Copy Markdown

@zacjansheski

Copy link
Copy Markdown
Contributor

Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved

@mathesoncalum mathesoncalum merged commit 1e42a8c into musescore:main Jun 2, 2026
8 of 9 checks passed
@mathesoncalum mathesoncalum deleted the pencil_thin_docks branch June 2, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants