Fix docks becoming "pencil thin" on close and reopen [Port to main]#63
Conversation
|
Actionable comments posted: 0 |
📝 WalkthroughWalkthroughThis pull request refines the dock window system's lifecycle management across three components. The QML loader for dock panels now requires both visibility and an initialization flag before activating, ensuring proper initialization sequencing. The C++ page deinitialization now explicitly calls cleanup on each dock before disconnecting. Additionally, macOS-specific widget sizing logic was refactored to always update the quick item size instead of returning early, providing consistent behavior with or without a floating window. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build |
|
Build dispatched: https://github.com/musescore/muse_framework/actions/runs/26584025762 |
|
/build |
|
Build dispatched: https://github.com/musescore/muse_framework/actions/runs/26623769284 |
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
Ports the framework part of musescore/MuseScore#33402
Build configuration
musescore: musescore/MuseScore/main
musescore platforms: linux_x64 linux_arm64 macos windows_x64 windows_portable