palette: switch Color literals to keyed form to silence go vet#26
Open
c-tonneslan wants to merge 1 commit into
Open
palette: switch Color literals to keyed form to silence go vet#26c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
go vet has been warning about thousands of unkeyed gamut.Color literals across the palette files. The Color struct only has three fields (Name, Color, Reference) so the literals are unambiguous today, but the lint warning makes the package noisy to use and would catch a real bug if a field ever gets added. Mechanical search-and-replace, no behaviour change. Closes muesli#13 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
`go vet` has been warning about ~2,700 unkeyed `gamut.Color` literals across the palette files. `Color` has three fields (Name, Color, Reference) so the literals are unambiguous today, but the lint noise is real and a future field addition would silently break those literals.
Mechanical search-and-replace, no behaviour change. `go test ./...` and `go vet ./...` are clean.