Repository navigation
CHANGELOG: renaming inbound_count went unnoticed by the suite - #116
Merged
Merged
Conversation
The only test of get-page-stats' inbound_count checked its absence after a failed read, and none expected it present; renaming it left the suite green. Also notes the three negative message checks that could no longer fire, with how they were found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry for #115 under
[Unreleased]→ Fixed. No code changes.The only test of
get-page-stats'inbound_countchecked its absence after a failed read and none expected it present, so renaming it left all 3265 tests green. The entry also records the three negative message checks that could no longer fire and how they were found (the 154 checks of the form"text" not in …, each asked whether the code still emits the text and whether a test expects it), with the mutation that checks the replacements.