Repository navigation
fix/450 null source guard - #563
Open
user-Param wants to merge 2 commits into
Open
user-Param wants to merge 2 commits into
user-Param wants to merge 2 commits into
Conversation
user-Param
commented
Oct 31, 2026
user-Param
commented
- fix(indexed): apply lineShift before comparing with next section offset
- fix(consumer): guard against null source in _findSourceIndex and sourceContentFor (TypeError: Cannot read property 'indexOf' of null #450)
In IndexedSourceMapConsumer.generatedPositionFor, allGeneratedPositionsFor, and eachMapping, the section-boundary check compared the section-relative generated line against the next section's absolute generated line offset before applying lineShift. This meant the clamp never triggered for sections with a nonzero line offset, leaving lastColumn as Infinity. Fixes mozilla#542 and mozilla#539.
…ceContentFor (mozilla#450) Add null/undefined checks at the start of _findSourceIndex and both sourceContentFor implementations. When aSource is null or undefined (e.g. from an unprocessed HTTP query parameter), return -1 or null instead of potentially throwing 'Cannot read property indexOf of null'. Fixes mozilla#450.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.