Skip to content

add 'moveit2_tutorials' exec dependency - #218

Draft
christian-rauch wants to merge 1 commit into
moveit:ros2from
christian-rauch:patch-1
Draft

add 'moveit2_tutorials' exec dependency#218
christian-rauch wants to merge 1 commit into
moveit:ros2from
christian-rauch:patch-1

Conversation

@christian-rauch

@christian-rauch christian-rauch commented Aug 19, 2026

Copy link
Copy Markdown
Member

The moveit2_tutorials package is used here:

rviz_base = os.path.join(get_package_share_directory("moveit2_tutorials"), "launch")

but it is not declared as runtime dependency.

The package and files in question are here:
https://github.com/moveit/moveit2_tutorials/tree/humble/doc/tutorials/quickstart_in_rviz/launch

In addition to this PR, the moveit2_tutorials package needs to be released.

Summary by CodeRabbit

  • Chores
    • Added the required MoveIt tutorial package dependency to the Panda MoveIt configuration.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2811c4e6-bdad-4f07-a151-c1dc69852d7d

📥 Commits

Reviewing files that changed from the base of the PR and between c55b102 and 3f432de.

📒 Files selected for processing (1)
  • panda_moveit_config/package.xml

Included review availability: Your plan provides up to 3 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The Panda MoveIt configuration package now declares moveit2_tutorials as an execution dependency.

Changes

Panda MoveIt dependency

Layer / File(s) Summary
Declare tutorial execution dependency
panda_moveit_config/package.xml
Adds moveit2_tutorials to the package's execution dependencies.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3f432

This localized manifest change adds the declared runtime dependency needed by the package, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: rhaschke

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the addition of the moveit2_tutorials execution dependency, which is the main change.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rhaschke rhaschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panda_moveit_config must not depend on moveit2_tutorials. It should be the other way around!
The corresponding files should be moved/copied from moveit2_tutorials.

@christian-rauch
christian-rauch marked this pull request as draft August 19, 2026 11:53
@christian-rauch

Copy link
Copy Markdown
Member Author

I set this back to draft and opened #219 instead.

I also noticed that I created #213 previously with a similar dependency issue.

How should we resolve these circular dependency issues?

@rhaschke

Copy link
Copy Markdown
Contributor

How should we resolve these circular dependency issues?

As I suggested before:
The corresponding files should be moved/copied from moveit2_tutorials.

@christian-rauch

Copy link
Copy Markdown
Member Author

How should we resolve these circular dependency issues?

As I suggested before: The corresponding files should be moved/copied from moveit2_tutorials.

How is this possible with the moveit_ros_move_group dependency? It is also marked as "circular dependency".

I think the only solution is to move moveit_resources_panda_moveit_config, and others, to the moveit2 repo.

@rhaschke

Copy link
Copy Markdown
Contributor

How is this possible with the moveit_ros_move_group dependency? It is also marked as "circular dependency".

That's a different dependency than moveit2_tutorials. The dependency order should be as follows:
moveit_resources < moveit2 < moveit2_tutorials

moveit_resources is a utility package only. It should not pull in any moveit2 packages.

Hence, I said: Copy the files (.rviz, .launch) from moveit2_tutorials, which are currently incorrectly referenced from within moveit_resources. These files obviously should reside in moveit_resources, not in moveit2_tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants