add 'moveit2_tutorials' exec dependency - #218
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 3 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Panda MoveIt configuration package now declares ChangesPanda MoveIt dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized manifest change adds the declared runtime dependency needed by the package, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
rhaschke
left a comment
There was a problem hiding this comment.
panda_moveit_config must not depend on moveit2_tutorials. It should be the other way around!
The corresponding files should be moved/copied from moveit2_tutorials.
As I suggested before: |
How is this possible with the I think the only solution is to move |
That's a different dependency than moveit2_tutorials. The dependency order should be as follows:
Hence, I said: Copy the files (.rviz, .launch) from |
The
moveit2_tutorialspackage is used here:moveit_resources/panda_moveit_config/launch/moveit_rviz.launch.py
Line 50 in c55b102
but it is not declared as runtime dependency.
The package and files in question are here:
https://github.com/moveit/moveit2_tutorials/tree/humble/doc/tutorials/quickstart_in_rviz/launch
In addition to this PR, the
moveit2_tutorialspackage needs to be released.Summary by CodeRabbit