Skip to content

Fix severe warning from class loader in servo (backport #3577) - #3597

Closed
mergify[bot] wants to merge 1 commit into
humblefrom
mergify/bp/humble/pr-3577
Closed

Fix severe warning from class loader in servo (backport #3577)#3597
mergify[bot] wants to merge 1 commit into
humblefrom
mergify/bp/humble/pr-3577

Conversation

@mergify

@mergify mergify Bot commented Oct 13, 2025

Copy link
Copy Markdown

Description

To fix "SEVERE WARNING" from class loader in moveit_servo, created the class loader as a member variable instead of creating it on the stack.

This fixes the following error:

[servo_node-20] Warning: class_loader.ClassLoader: SEVERE WARNING!!! Attempting to unload library while objects created by this loader exist in the heap! You should delete your objects before attempting to unload the library or destroying the ClassLoader. The library will NOT be unloaded.

This is an automatic backport of pull request #3577 done by [Mergify](https://mergify.com).

* Add class loader member variable instead of  creating on stack

* Fix formatting to satisfy clang

---------

Co-authored-by: AndyZe <andyz@utexas.edu>
Co-authored-by: Nathan Brooks <nathanbrooks@picknik.ai>
(cherry picked from commit 92654dd)

# Conflicts:
#	moveit_ros/moveit_servo/include/moveit_servo/servo.hpp
#	moveit_ros/moveit_servo/src/servo.cpp
@mergify

mergify Bot commented Oct 13, 2025

Copy link
Copy Markdown
Author

Cherry-pick of 92654dd has failed:

On branch mergify/bp/humble/pr-3577
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 92654dd1b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   moveit_ros/moveit_servo/include/moveit_servo/servo.hpp
	both modified:   moveit_ros/moveit_servo/src/servo.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@MatthijsBurgh

Copy link
Copy Markdown
Contributor

@AndyZe please resolve the conflicts

@nbbrooks
nbbrooks marked this pull request as draft November 27, 2025 03:17
@rhaschke

Copy link
Copy Markdown
Contributor

The PR doesn't apply to Humble, because the refactoring (#2224) isn't part of the Humble branch.
On Humble, the smoothing loader is already persistent:

pluginlib::ClassLoader<online_signal_smoothing::SmoothingBaseClass> smoothing_loader_;

@rhaschke rhaschke closed this Aug 31, 2026
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Aug 31, 2026
@rhaschke
rhaschke deleted the mergify/bp/humble/pr-3577 branch August 31, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants