Remove private repo names from a public repo - #7
Merged
Conversation
This repo is public and named four private ones throughout: in the README, the version catalog comment, two convention-plugin sources and the workflow's usage example. Following the placeholder convention already applied to the README by hand (foo, long-name). Also drops "personal-OS" and the self-hosted F-Droid reference, neither of which a consumer needs to know and both of which describe private infrastructure. Library names stay. A shared catalog listing health-connect, mlkit or maps-compose says what the apps can do, not which repos exist. Verified the sample still builds and the AppName error message still reads correctly with the new placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo is public and named four private ones throughout. Following the
foo/long-nameplaceholder convention already applied to the README by hand.README.mdlibs.versions.tomlAppName.ktAndroidAppConventionPlugin.ktandroid-app.ymlapp-name: **finance**/release-title: **Finance** (Android)Also drops "personal-OS" (3 files) and the self-hosted F-Droid reference, neither of which a consumer needs and both of which describe private infrastructure.
Library names stay. A shared catalog listing
health-connect,mlkit-barcodeormaps-composereveals what the apps can do, not which repos exist. Say if you want those genericised too, though it would make the catalog much less useful.Sample builds green and the
AppNameerror message still reads correctly with the new placeholder.