README: drop /** from the submodule path filter - #6
Merged
Conversation
A submodule bump changes the gitlink path itself, and a /** pattern needs a segment beneath it, so it never matched. Both bump PRs sat with no Android run at all: an app could take a catalog update without ever building or releasing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by bumping film-roll's and finance's submodule pins: neither PR triggered the Android workflow.
A submodule bump changes the gitlink path itself:
packages/android-config/**requires a segment beneath that path, so it never matches. The consequence is that an app could take a catalog update and never build or release it, which quietly defeats the whole propagation path.Fixed in all four app workflows too.