Fetch only the android-config submodule - #4
Merged
Conversation
submodules: recursive broke finance: it also tries to clone js-config and go-config, which are private, so the default token cannot read them and checkout fails before any build step runs. film-roll never hit this because android-config is its only submodule. The Android build reads none of those, so it now initialises packages/android-config alone. That is public, so the pipeline needs no PAT at all, and it skips cloning two repos it would never use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finance's migration failed at checkout, before any build step:
submodules: recursivealso tries to clonejs-configandgo-config, which are private. The defaultGITHUB_TOKENcan't read them. film-roll never hit this becauseandroid-configis its only submodule.The Android build reads neither of those. So instead of wiring a PAT through the pipeline, it now initialises
packages/android-configalone, which is public and needs no token. It also skips cloning two repos it would never use.Fails with a clear message if the submodule is absent, rather than building against a missing catalog.