Write local.properties from repo vars and secrets - #3
Merged
Conversation
The apps inject their API base URL two different ways: health and footprint write local.properties from an API_BASE_URL variable, finance passes a FINANCE_API_BASE_URL Gradle property. Same value, two mechanisms and two variable names. The workflow now writes local.properties from API_BASE_URL, DEVICE_API_KEY and GOOGLE_MAPS_API_KEY, in both the verify and release jobs so they compile the same buildConfigFields. Keys absent from the repo are not written, so an app that does not use one keeps its build default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for migrating finance.
The three API-backed apps inject their base URL two different ways:
API_BASE_URLlocal.propertiesFINANCE_API_BASE_URLSame value, two names, two mechanisms. The shared workflow now owns it: it writes
local.propertiesfromvars.API_BASE_URL,secrets.DEVICE_API_KEYandsecrets.GOOGLE_MAPS_API_KEY.Only keys that are set get written, so film-roll (which uses none of them) is unaffected and keeps its build defaults. Runs in both
verifyandreleaseso the two jobs compile identicalbuildConfigFields. The step logs which keys it wrote, never the values.