lint: report warnings, don't fail on them - #1
Merged
Conversation
warningsAsErrors turned six cosmetic findings in film-roll into a red build: an inlined int constant that no-ops on older APIs, two forward-compatible widget attributes, and three resource nits. None was a bug. A gate that fires on themed-icon advice is one that gets switched off entirely. Real lint errors still fail via abortOnError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while migrating film-roll:
warningsAsErrors = trueturned six cosmetic lint findings into a red build, none of them a bug.InlinedApionHapticFeedbackConstants.CONFIRM(an int constant that no-ops below API 30)UnusedAttributeon forward-compatible widget sizing hintsObsoleteSdkInt,UnusedResources,MonochromeLauncherIconon launcher resourcesA gate that fires on themed-icon advice gets switched off entirely, which costs more than it saves.
abortOnErrorstays, so genuine lint errors still fail.