This repository was archived by the owner on Aug 10, 2026. It is now read-only.
Fix CI integration test failures: add undici dep, loosen geo assertions - #164
Merged
Conversation
1. Add undici as an explicit dependency. The proxy support in
lib/utils/httpRequest.js uses require('undici').ProxyAgent, but
require('undici') is not reliably available as a built-in across
Node 18-24 (fails on Node 24.18, works on 24.19). Making it an
explicit npm dependency ensures ProxyAgent is always resolvable
when a proxy is configured, so the 'No connection' error test
actually fails to connect instead of silently bypassing the proxy.
2. Relax the placeSearchText '123+main+street' coordinate assertion
to global bounds (-90..90, -180..180). Google returns results in
different countries depending on the calling IP's region; from the
CI datacenter it returned Italy (lng 14.49), not the US. The test
now just verifies a valid Earth coordinate when results exist.
npm audit: 0 vulnerabilities. Unit: 433 passing. Integration: 39 passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add undici as an explicit dependency. The proxy support in lib/utils/httpRequest.js uses require('undici').ProxyAgent, but require('undici') is not reliably available as a built-in across Node 18-24 (fails on Node 24.18, works on 24.19). Making it an explicit npm dependency ensures ProxyAgent is always resolvable when a proxy is configured, so the 'No connection' error test actually fails to connect instead of silently bypassing the proxy.
Relax the placeSearchText '123+main+street' coordinate assertion to global bounds (-90..90, -180..180). Google returns results in different countries depending on the calling IP's region; from the CI datacenter it returned Italy (lng 14.49), not the US. The test now just verifies a valid Earth coordinate when results exist.
npm audit: 0 vulnerabilities. Unit: 433 passing. Integration: 39 passing.