Repository navigation
refactor(app): move the application ID and package to org.molstar.viewer - #4
Merged
Merged
Conversation
- Replace io.github.daylight00.molstarandroid in applicationId, namespace, and the Kotlin package - Move the four Kotlin sources to org/molstar/viewer - Update the device and CI scripts that name the app or its activity - Installed 0.2.1 builds will not update in place; the new ID installs as a separate app Signed-off-by: David Hyunyoo Jang <hwjang00@snu.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
io.github.daylight00.molstarandroidnamespace with one owned by the Mol* projectWhat changed
applicationId,namespace, and the Kotlin package becomeorg.molstar.viewerorg.molstar.viewer.candidate,.debugorg/molstar/viewerImpact
Verified
./gradlew :app:testCandidateDebugUnitTest :app:assembleCandidateDebugpassesorg.molstar.viewer.candidate.debugandorg.molstar.viewer.MainActivityverify-automation-contract.mjsandverify-public-boundary.mjspassscripts/verify.sh(blocked by the sandbox shell guard), emulator smoke (runs in CI)