Repository navigation
chore(desktop): ignore zip extract advisories - #147
Merged
Merged
Conversation
Contributor
Deploying Modrex previews with
|
| App preview: | https://app-preview.modrex.net/pr/147 |
| Site preview: | https://site-preview.modrex.net/pr/147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The security audit now fails on every branch because of three new advisories for the
zipcrate (RUSTSEC-2026-0367, RUSTSEC-2026-0368 and RUSTSEC-2026-0369). All three are aboutZipArchive::extractandZipStreamReader::extract, which can apply file permissions and create links outside the target folder. Neither affects Modrex:extract. Every archive is read entry by entry and written throughsafe_dest, the same reason thesevenz-rustadvisory is already ignored.clippy.tomlnow forbidsZipArchive::extractandZipArchive::extract_unwrapped_root_dir, so CI fails if anyone starts using them.ZipStreamReaderis not public in thezipversion Modrex uses.zip4 insidetauri-plugin-updater) only unpacks a zip after the minisign check, andcreateUpdaterArtifactsships the signed NSIS installer itself, so no update Modrex installs is a zip.The advisories are added to
.cargo/audit.tomlwith that reasoning and a note to remove them once Modrex and the updater both usezip9 or later.Upgrading Modrex to
zip9 was tried first. It needslibbz2-rs-sysfor bzip2 support, whosebzip2-1.0.6license is not on the accepted list, so that upgrade is left for a separate decision. The latest stabletauri-plugin-updaterstill depends onzip4.Type of change
Translation (if applicable)
See the translation guide.
Validation
bun checks)Details:
cargo auditreports no vulnerabilities.cargo clippy --all-targets -- -D warningspasses, and a temporary call toZipArchive::extractwas rejected by it as a disallowed method. No dependency changes.