Repository navigation
feat(desktop): split installed mods by location - #146
Merged
Merged
Conversation
Contributor
Deploying Modrex previews with
|
| App preview: | https://app-preview.modrex.net/pr/146 |
| Site preview: | https://site-preview.modrex.net/pr/146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the Installed page by where mods are installed, so mods from different folders no longer share one mixed list.
Type of change
Translation (if applicable)
See the translation guide.
Validation
bun checks)Details:
cargo fmt,cargo clippyandcargo testpass, as dobun typecheck,bun lint, the format check,bun check-i18n,bun check-commands, the renderer tests and the preview tests. Every commit was also checked on its own. Checked by hand in the preview on PAYDAY 3, Crime Boss, RAID and Browse Mods, including the minimum window width. Two App.test.tsx tests are flaky under full suite load on main as well. No dependency changes.Known limitation, unchanged by this PR: UE4SS mods nested inside an app folder are probably not loaded by UE4SS.