Skip to content

time: an invalid --local-timezone crashes the server with a traceback #5001

Description

@cliffhall

Problem

An invalid --local-timezone value makes serve() raise before the stdio transport opens, so the process dies with a Python traceback.

Where it is pinned

src/time/tests/test_protocol.py: test_invalid_local_timezone_fails_before_the_transport_opens, added in #4972 (Wave 1 of #4857). Each of these tests carries a KNOWN BUG marker: it asserts the current, wrong behavior, so the fix has to change it.

Expected

A one-line error naming the invalid timezone, with a non-zero exit.

Done when

  • The behavior above is fixed, in the legacy-era (2025-11-25) server on SDK 1.x.
  • The pinning tests assert the correct behavior, and their KNOWN BUG markers are gone.
  • The per-file 90% coverage gate still passes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingserver-timeReference implementation for the Time MCP server - src/timev2

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions