Skip to content

Feature/aci test refactor#527

Merged
mmckechney merged 3 commits into
masterfrom
feature/aci_test_refactor
Jun 5, 2026
Merged

Feature/aci test refactor#527
mmckechney merged 3 commits into
masterfrom
feature/aci_test_refactor

Conversation

@mmckechney

Copy link
Copy Markdown
Owner

This pull request refactors and extends the external integration test automation for SQL Server and PostgreSQL, improves test script reliability, and updates documentation and helper scripts to match the new structure. The main improvements are the separation of SQL Server and PostgreSQL external test runners, enhanced dynamic firewall handling, and corresponding updates to helper scripts and documentation.

Test runner separation and enhancements:

  • Split the previous combined test runner run_all_external_tests_in_aci.ps1 into two scripts: run_all_sqlserver_external_tests_in_aci.ps1 (for SQL Server) and the new run_all_postgres_external_tests_in_aci.ps1 (for PostgreSQL), each dynamically filtering tests based on deployed platforms. The SQL Server script was renamed and PostgreSQL logic was moved to its own script. [1] [2]
  • Updated the SQL Server test runner to focus only on SQL Server tests, removing all PostgreSQL logic and related platform checks. [1] [2]
  • The new PostgreSQL test runner script dynamically determines which compute platforms are available and only runs the relevant PostgreSQL tests, skipping unavailable combinations with clear messaging.

Firewall and reliability improvements:

  • Improved grant_identity_permissions.ps1 to automatically detect and add blocked client IP addresses to the firewall, retry permission grants up to three times, and clean up any dynamically-created firewall rules after execution.

Helper script and documentation updates:

  • Updated Build_Images.bat and container_prompts.bat to point to the new, separate SQL Server and PostgreSQL test runner scripts, and adjusted working directory paths to a new location. [1] [2] [3] [4]
  • Updated .github/copilot-instructions.md to document the new test runner scripts and clarify how external tests are executed.

These changes make the test automation more modular, robust, and easier to maintain.
[Copilot is generating a summary...]

@mmckechney mmckechney merged commit 126af02 into master Jun 5, 2026
2 of 4 checks passed
@mmckechney mmckechney deleted the feature/aci_test_refactor branch June 5, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant