Feature/aci test refactor#527
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the external integration test automation for SQL Server and PostgreSQL, improves test script reliability, and updates documentation and helper scripts to match the new structure. The main improvements are the separation of SQL Server and PostgreSQL external test runners, enhanced dynamic firewall handling, and corresponding updates to helper scripts and documentation.
Test runner separation and enhancements:
run_all_external_tests_in_aci.ps1into two scripts:run_all_sqlserver_external_tests_in_aci.ps1(for SQL Server) and the newrun_all_postgres_external_tests_in_aci.ps1(for PostgreSQL), each dynamically filtering tests based on deployed platforms. The SQL Server script was renamed and PostgreSQL logic was moved to its own script. [1] [2]Firewall and reliability improvements:
grant_identity_permissions.ps1to automatically detect and add blocked client IP addresses to the firewall, retry permission grants up to three times, and clean up any dynamically-created firewall rules after execution.Helper script and documentation updates:
Build_Images.batandcontainer_prompts.batto point to the new, separate SQL Server and PostgreSQL test runner scripts, and adjusted working directory paths to a new location. [1] [2] [3] [4].github/copilot-instructions.mdto document the new test runner scripts and clarify how external tests are executed.These changes make the test automation more modular, robust, and easier to maintain.
[Copilot is generating a summary...]