Skip to content

chore: standardize release process#67

Open
tylerjroach wants to merge 1 commit intomasterfrom
chore/standardize-release-process
Open

chore: standardize release process#67
tylerjroach wants to merge 1 commit intomasterfrom
chore/standardize-release-process

Conversation

@tylerjroach
Copy link
Copy Markdown
Contributor

No description provided.

@tylerjroach tylerjroach requested review from a team and ketanmixpanel April 23, 2026 20:42
@rahul-mixpanel
Copy link
Copy Markdown

Review Summary

The Maven adaptations look good overall. The multi-module setup with analytics and openfeature is well structured. A few issues to address:

Issue: Unpinned Action SHAs

This PR uses version tags (e.g., actions/checkout@v4) instead of pinned SHAs like the other repos. For consistency and security, consider pinning:

Current Pinned SHA
actions/checkout@v4 actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
actions/setup-java@v4 actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
actions/cache@v4 actions/cache@... (get latest SHA)

Same suggestions as other PRs:

  1. PR title check - Currently only allows feat|fix|chore types.

  2. Changelog generation - Only captures commits with module scope.

  3. README update - The sed pattern fails silently if format doesn't match.

  4. Draft release notes - Consider adding a fallback if notes extraction returns empty.


Good to merge after pinning action SHAs for consistency with other Mixpanel repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants