Closed
Stabilize cross-version CI by skipping incompatible CheckboxButton edge-case snapshots before alpha.933#2683
Conversation
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job 'cross-version'
Stabilize cross-version CI by skipping incompatible CheckboxButton edge-case snapshots before alpha.933
Jul 22, 2026
mfal
marked this pull request as ready for review
July 22, 2026 12:55
mfal
requested review from
Jan-Eimertenbrink,
Lisa18289,
ins0 and
maaaathis
as code owners
July 22, 2026 12:55
mfal
reviewed
Jul 22, 2026
mfal
left a comment
Member
There was a problem hiding this comment.
I don't see any changes to the CheckboxButton in .933
There was a problem hiding this comment.
Pull request overview
Updates the remote-react-components visual cross-version compatibility suite to avoid deterministic snapshot mismatches for CheckboxButton edge-case markup when running against older published versions that still produce a different DOM structure in the in-process harness.
Changes:
- Adjusted the cross-version skip boundary for the
CheckboxButtonedge-case visual snapshot to skip versions< 0.2.0-alpha.933. - Updated the inline comment to document why
alpha.932remains incompatible for this specific scenario.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cross-versionActions job failed because the in-process compatibility suite comparedCheckboxButtonedge-case HTML against versions that still emit an older structural shape (0.2.0-alpha.932). This produced a deterministic snapshot mismatch in theprevioustarget.Root cause alignment
Checkbox edge cases(CrossVersion)was gated withbelow: "0.2.0-alpha.926", but structural parity with current host output for this scenario only holds from0.2.0-alpha.933onward.Change made
packages/remote-react-components/src/tests/visual/CheckboxButton.browser.test.tsx:crossVersion({ below: "0.2.0-alpha.926" })crossVersion({ below: "0.2.0-alpha.933" })Example