chore: use Star Wars example content in stories and tests - #2660
Merged
Conversation
mfal
requested review from
Jan-Eimertenbrink,
Lisa18289,
ins0 and
maaaathis
as code owners
July 16, 2026 11:45
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
mfal
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Replaces the placeholder/example content shown in Storybook stories and in
the remote-react-components visual/behaviour tests with themed Star Wars
content (English). The goal is purely cosmetic example data — no component
behaviour, props, or public API changes.
What changed:
- dummyText.ts (shared placeholder) themed to opening-crawl style text.
- ~90 story files: filler text, example names/emails, list/table/menu/nav
data, tooltips, file names, etc. themed.
- ~40 remote-react-components visual tests + Avatar behaviour test: free
example content themed (assertions kept in sync where rendered strings
are asserted).
- Regenerated -darwin visual screenshots to match the new content.
Semantically meaningful strings are deliberately preserved: state/variant/
size/status labels (e.g. "Primary solid", "Disabled", "Selected"), slot
labels ("Text", "Content", "Heading", "Label"), story titles/exports, and
prop values / argType options.
Note: only macOS (-darwin) screenshots could be regenerated locally. The
Linux baseline that CI checks must be regenerated via the `update-screenshots`
PR label.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mfal
force-pushed
the
claude/storybooks-star-wars-c95631
branch
from
July 17, 2026 09:52
9e6e6f4 to
a8c9381
Compare
mfal
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Co-authored-by: mfal <4696750+mfal@users.noreply.github.com>
mfal
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Lisa18289
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Themes the example content shown in Storybook stories and in the
remote-react-componentsvisual/behaviour tests to Star Wars (English).Purely cosmetic example data — no component behaviour, props, or public API
changes.
Why
A fun, consistent example-data theme across the component playground and tests.
Changes
dummyText.ts(shared placeholder) → opening-crawl style text.data, tooltips, file names, chart labels, etc.
remote-react-componentsvisual tests +Avatarbehaviour test —free example content themed; assertions kept in sync where a rendered string
is asserted (e.g.
Listfilter input,Avataraccessible name).-darwinvisual screenshots regenerated to match the new content.Deliberately preserved (semantic strings)
Per review feedback, strings that document what is being demonstrated were
kept as-is:
Primary solid,Disabled,Selected,WarningText,Content,Heading,LabelargTypeoptionsCI runs visual tests on ubuntu (Linux), but these could only be
regenerated locally on macOS (
-darwin). The Linux baseline is stillstale, so the visual job will be red until it's regenerated.
➡️ Please add the
update-screenshotslabel to this PR to regenerate andcommit the Linux screenshots.
Verification
test:compile(tsc) ✅components+remote-react-componentsAvatarbrowser test ✅ (webkit)🤖 Generated with Claude Code