Repository navigation
Conversation
commit: |
aidenybai
marked this pull request as ready for review
October 17, 2026 01:52
aidenybai
marked this pull request as draft
October 17, 2026 02:16
aidenybai
marked this pull request as ready for review
October 17, 2026 03:00
aidenybai
marked this pull request as draft
October 17, 2026 03:02
aidenybai
marked this pull request as ready for review
October 17, 2026 03:51
aidenybai
marked this pull request as draft
October 17, 2026 04:05
aidenybai
marked this pull request as ready for review
October 17, 2026 06:06
aidenybai
marked this pull request as draft
October 22, 2026 12:21
aidenybai
marked this pull request as ready for review
October 22, 2026 12:50
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A direct lifecycle state update guarded by an adjacent return for unchanged props should avoid the did-update warning.
What changed
Recognize the bounded equality-return pattern for a proven native React superclass and readonly previous props. Retain warnings for uncertain ownership, provider mutation, escaped receivers, and unsupported control flow.
Resolve runtime references and writes to the nearest genuine value when erased TypeScript declarations share its name. Keep erased-only fallback and declaration identity intact. Reuse the shared erased-binding, namespace, and runtime-value helpers for conservative provider admission. Shared semantic controls cover imports, parameters, writes, local values, namespaces, and computed keys. Independent regressions and synthetic fuzz controls exercise the rule boundary. The patch changesets cover diagnostic and resolver behavior.
Preserve the original stacked base and incorporate validated parent
1f7953c59095b1a43bbc0b0ca2a5854ac0eda690. Verify the clean merge tree and unchanged child-only files. Merge the parent first.Test plan
f8507661b8efaccb5206dda81e8f00388a85ae08preserves the actual stacked base1f7953c59095b1a43bbc0b0ca2a5854ac0eda690. All nine local checks passed on its exact canonical source tree: prepare, uncached full tests, lint, uncached typecheck, format check, registry check, uncached five-package build, JSON schema smoke, and strict scoped fuzzing.Remote parity was not run because the required Daytona credentials are unavailable; a local RDE checkout is also unavailable. These local controls do not establish repository parity or application runtime behavior.
Main-only CI does not run for this stacked base. Available exact-head checks, review threads and mergeability gate readiness; merge the stacked parent first.
Completed performance and regression review
Exact target and fixed general full-engine comparisons passed. Each workload includes activation plus five cold and five hot timing samples per revision and dedicated CPU captures; raw gzip artifacts and timing rows were independently read back. All four wall cohorts are stable under the fixed 10% plus 250 ms budget; total CPU and RSS manual flags are clear. Every complete unrelated diagnostic and all five project-context fields match. The general workload retains all 256 diagnostics. These are finite local measurements.
Target-specific evidence: the intended target deltas match retained complete primary diagnostic objects or independently activated native per-file counts, including positive and refusal controls.
All available exact-head checks are green, including the natural react-doctor run started after marking this PR ready. The live stacked base and main were rechecked. This PR is ready for review; merge the stacked parent first.