Skip to content

FPFNFIXAPEX allow readonly state initialized with closed literal Object.freeze - #1993

Open
aidenybai wants to merge 7 commits into
codex/audit-omitted-state-setterfrom
codex/audit-closed-literal-state-freeze
Open

aidenybai wants to merge 7 commits into
codex/audit-omitted-state-setterfrom
codex/audit-closed-literal-state-freeze

Conversation

@aidenybai

@aidenybai aidenybai commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Why

Readonly state initialized with a closed native Object.freeze literal can omit its setter without a hook-use-state warning.

What changed

Accept closed primitive and explicitly frozen nested literals. Keep warnings for aliases, spreads, holes, accessors, unsupported values, provider mutation and mismatched setters.

Integrate current stacked parent 1f7953c59095b1a43bbc0b0ca2a5854ac0eda690 through a normal merge, preserving the original PR base and its shared provider-proof and numeric-data performance repairs.

The target workload explicitly enables this default-off rule while retaining the default full-engine checks.

Validation

Reviewed head: e4588603923fa5c6a2cbbee9f6658bd5928b8bee. All nine local gates passed: prepare, full uncached tests, lint, uncached typecheck, format, generated registry, a fresh five-package build, JSON report smoke, and strict target-rule fuzzing (500 configured iterations, seed 42, required target firing). Normal commit hooks passed, and committed source plus all 175 runtime files match the validated tree.

Remote parity was not run because the required Daytona credentials are unavailable. A local RDE checkout is also unavailable. Existing patch changesets remain in the PR.

Local evidence: tmp/fpfn-regression-profile-2026-10-20/continue-20261022/stack-drift-review-v1/pr-1993-validation-v2/proof.json and pr-1993-normal-merge-commit-v1/proof.json in that directory.

Completed performance and regression review

Exact target and fixed general full-engine comparisons passed. Each workload includes activation plus five cold and five hot timing samples per revision and dedicated CPU captures; raw gzip artifacts and timing rows were independently read back. All four wall cohorts are stable under the fixed 10% plus 250 ms budget; total CPU and RSS manual flags are clear. Every complete unrelated diagnostic and all five project-context fields match. The general workload retains all 256 diagnostics. These are finite local measurements.

Workload Cold median, base → head Hot median, base → head
Authored target 542.8 → 541.1 ms 345.3 → 349.0 ms
General 128 701.0 → 706.2 ms 372.5 → 374.6 ms

Target-specific evidence: the default-off rule is explicitly enabled and matches independent per-file native counts, 67 → 58 warnings.

All available exact-head checks are green, including the natural react-doctor run started after marking this PR ready. The live stacked base and main were rechecked. This PR is ready for review; merge the stacked parent first.

@pkg-pr-new

pkg-pr-new Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1993
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1993
npm i https://pkg.pr.new/react-doctor@1993

commit: e458860

@aidenybai
aidenybai marked this pull request as ready for review October 17, 2026 01:52
@aidenybai
aidenybai marked this pull request as draft October 17, 2026 02:16
@aidenybai
aidenybai marked this pull request as ready for review October 17, 2026 03:00
@aidenybai
aidenybai marked this pull request as draft October 17, 2026 03:02
@aidenybai
aidenybai marked this pull request as ready for review October 17, 2026 03:43
@aidenybai
aidenybai marked this pull request as draft October 17, 2026 04:05
@aidenybai
aidenybai marked this pull request as ready for review October 17, 2026 04:52
@aidenybai
aidenybai marked this pull request as draft October 22, 2026 11:16
@aidenybai
aidenybai marked this pull request as ready for review October 22, 2026 11:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant