Repository navigation
Conversation
commit: |
aidenybai
marked this pull request as ready for review
October 17, 2026 01:52
aidenybai
marked this pull request as draft
October 17, 2026 02:16
aidenybai
marked this pull request as ready for review
October 17, 2026 03:00
aidenybai
marked this pull request as draft
October 17, 2026 03:02
aidenybai
marked this pull request as ready for review
October 17, 2026 03:43
aidenybai
marked this pull request as draft
October 17, 2026 04:05
aidenybai
marked this pull request as ready for review
October 17, 2026 04:52
aidenybai
marked this pull request as draft
October 22, 2026 11:16
aidenybai
marked this pull request as ready for review
October 22, 2026 11:57
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Readonly state initialized with a closed native
Object.freezeliteral can omit its setter without ahook-use-statewarning.What changed
Accept closed primitive and explicitly frozen nested literals. Keep warnings for aliases, spreads, holes, accessors, unsupported values, provider mutation and mismatched setters.
Integrate current stacked parent
1f7953c59095b1a43bbc0b0ca2a5854ac0eda690through a normal merge, preserving the original PR base and its shared provider-proof and numeric-data performance repairs.The target workload explicitly enables this default-off rule while retaining the default full-engine checks.
Validation
Reviewed head:
e4588603923fa5c6a2cbbee9f6658bd5928b8bee. All nine local gates passed: prepare, full uncached tests, lint, uncached typecheck, format, generated registry, a fresh five-package build, JSON report smoke, and strict target-rule fuzzing (500 configured iterations, seed 42, required target firing). Normal commit hooks passed, and committed source plus all 175 runtime files match the validated tree.Remote parity was not run because the required Daytona credentials are unavailable. A local RDE checkout is also unavailable. Existing patch changesets remain in the PR.
Local evidence:
tmp/fpfn-regression-profile-2026-10-20/continue-20261022/stack-drift-review-v1/pr-1993-validation-v2/proof.jsonandpr-1993-normal-merge-commit-v1/proof.jsonin that directory.Completed performance and regression review
Exact target and fixed general full-engine comparisons passed. Each workload includes activation plus five cold and five hot timing samples per revision and dedicated CPU captures; raw gzip artifacts and timing rows were independently read back. All four wall cohorts are stable under the fixed 10% plus 250 ms budget; total CPU and RSS manual flags are clear. Every complete unrelated diagnostic and all five project-context fields match. The general workload retains all 256 diagnostics. These are finite local measurements.
Target-specific evidence: the default-off rule is explicitly enabled and matches independent per-file native counts, 67 → 58 warnings.
All available exact-head checks are green, including the natural react-doctor run started after marking this PR ready. The live stacked base and main were rechecked. This PR is ready for review; merge the stacked parent first.