Repository navigation
Conversation
… nullable cleanup (#1957) - Extend hasGuardedDeferredCleanup to handle subscriptions in addition to timers - Support subscriptions created in promise callbacks and cleaned up conditionally - Recognize LogicalExpression guards (e.g. subscription && subscription.remove()) - Add comprehensive tests for async subscription cleanup patterns - Add regression test in fuzz corpus Closes #1957 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 21, 2026 11:21
3 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1957.
An effect can wait for availability, stop a late subscription after cancellation, and release its current handle during cleanup.
effect-needs-cleanupstill reported this pattern because its guarded deferred-cleanup proof covered timers only.Changes
Validation
Current public head:
41da30539bd91a95087ab0d1cb89f251d21be635.Tree:
4797f062eadcae328923a55c1651f6cf8bb81e45, identical to signed local mergebaad3d839d2f0bc15dc8d72cb1159cd066ebedb0and prospective mergebca96f52909fb59827387c583b15f1af0d7fdf5a. The GitHub App commit itself is unsigned.js-set-map-lookupswarnings. All five messages and source contexts match main. The normal hooks completed successfully with their existing nonblocking Doctor step. Score fetches were blocked, so no score or target-rule CLI coverage is claimed.Limits
Iterator/helper initiation, complex producer flow, and aliases of declared API receivers remain outside this proof. The existing
forEachmissed-warning case remains recorded. External implementations must honor their declared API contracts.Opt-in fuzz, local RDE, and corpus parity were not run. Package manifests remain 0.9.22.