ci(v4-beta): pin internal setup-msvc-dev-cmd ref to @v4-beta#180
Merged
Conversation
While testing the MSVC + DISTUTILS_USE_SDK chain end-to-end against v4-beta from runenv-python-3 PR #88, the workflow files still pinned the internal `setup-msvc-dev-cmd` ref to `@v4`. That meant downstream consumers picked up the v4-beta WORKFLOW but the v4 ACTION (no DISTUTILS_USE_SDK), so setuptools still raised the "Microsoft Visual C++ 14.0 or greater is required" error. Bumps both node-matrix.yaml and node-matrix-pnpm.yaml to reference `setup-msvc-dev-cmd@v4-beta` so the full chain is on v4-beta. This is a TEMPORARY pin: when v4-beta -> v4 promotion happens (through the standard merge-beta flow), the ref should flip back to `@v4`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary pin to validate the MSVC + DISTUTILS_USE_SDK chain end-to-end against v4-beta from runenv-python-3 #88.
The workflow files in v4-beta still pin internal MSVC action ref to
@v4, so downstream consumers pick up the v4-beta WORKFLOW but the v4 ACTION (no DISTUTILS_USE_SDK), so freesasa pip wheel still fails.Bumps both
node-matrix.yamlandnode-matrix-pnpm.yamlto referencesetup-msvc-dev-cmd@v4-beta.To be reverted to
@v4once v4-beta -> v4 promotion lands (standard merge-beta flow). Logical companion of #177 (workflow step) and #179 (DISTUTILS_USE_SDK in action).