Skip to content

Fix conditional logic for target dependencies#87

Merged
mikeger merged 1 commit intomikeger:mainfrom
edi-medibank:patch-1
Apr 22, 2026
Merged

Fix conditional logic for target dependencies#87
mikeger merged 1 commit intomikeger:mainfrom
edi-medibank:patch-1

Conversation

@edi-medibank
Copy link
Copy Markdown
Contributor

@edi-medibank edi-medibank commented Apr 20, 2026

First of all, thanks @mikeger for such a great project ❤️ we are evaluating it and find it really useful.

One thing we faced is that in our local packages we define local dependencies via .target and the tool was not picking up this.

for example:

       .target(
            name: "FeatureFlags",
            dependencies: [
                .product(name: "Optimizely", package: "optimizely-swift-sdk"),
                .product(name: "Vexil", package: "Vexil"),
            ],
            path: "Sources/FeatureFlags"
        ),

        .target(
            name: "FeatureFlagsMocks",
            dependencies: [
                .target(name: "FeatureFlags"),
                .product(name: "Vexil", package: "Vexil"),
            ],
            path: "Sources/FeatureFlagsMocks"
        ),

So as we defined .target(name: "FeatureFlags"), instead of just "FeatureFlags", the dependency was not identified.

@mikeger mikeger merged commit fcd4d04 into mikeger:main Apr 22, 2026
4 checks passed
@mikeger
Copy link
Copy Markdown
Owner

mikeger commented Apr 22, 2026

@edi-medibank thanks for the contribution! I've added you to the contributors list, I hope it's OK from your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants