Skip to content

fix: keep directory separators visible when filtering npm scripts #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickiel wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

fix: keep directory separators visible when filtering npm scripts #2370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ba5c5
fix: keep directory separators visible when filtering npm scripts
patrickiel Jun 7, 2026
8594d3c
Merge branch 'main' into fix/npm-script-quickpick-keep-separators
patrickiel Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ui/debugNpmScript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export async function debugNpmScript(inFolder?: vscode.WorkspaceFolder | string)
// directory name so the user knows where it's coming from.
const multiDir = scripts.some(s => s.directory !== scripts[0].directory);
const quickPick = vscode.window.createQuickPick<ScriptPickItem>();
// Keep the original order while filtering so directory separators stay attached to their
// groups; sorting by match would reorder across groups and drop them. (sortByLabel is
// proposed API microsoft/vscode#73904, safe at runtime — cast to avoid the dependency.)
(quickPick as { sortByLabel?: boolean }).sortByLabel = !multiDir;

let lastDir: string | undefined;
const items: ScriptPickItem[] = [];
Expand Down