-
Notifications
You must be signed in to change notification settings - Fork 22
Release 0.7.4
#597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 0.7.4
#597
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
b66af2a
sync Release `0.7.3` (#549) (#557)
tnaum-ms b1ceade
chore(deps): bump lodash from 4.17.23 to 4.18.1
dependabot[bot] fe516d9
chore(deps): bump lodash from 4.17.23 to 4.18.1 (#556)
tnaum-ms 71bc70e
chore(deps-dev): bump handlebars from 4.7.8 to 4.7.9
dependabot[bot] ad18cb9
chore(deps-dev): bump handlebars from 4.7.8 to 4.7.9 (#552)
tnaum-ms 51f5ff3
chore(deps): bump lodash and @microsoft/api-extractor in /api
dependabot[bot] 3092d13
chore(deps): bump lodash and @microsoft/api-extractor in /api (#558)
tnaum-ms 68e14e3
docs: update CONTRIBUTING.md to include PR submission checklist and i…
tnaum-ms 1d84392
docs: improve CONTRIBUTING.md — PR checklist, correct Node/npm versio…
tnaum-ms e9ce511
feat: add Copy Reference context menu for databases and collections
bgaeddert 094a2dc
fix: update l10n bundle with new localization key for Copy Reference
bgaeddert 34c144b
style: fix prettier formatting in copyReference.ts
bgaeddert 32e6d3e
refactor: consolidate copy reference into shared helper and different…
bgaeddert 57888b4
chore(deps): bump follow-redirects from 1.15.11 to 1.16.0
dependabot[bot] 1e9351e
chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#586)
tnaum-ms 3896769
feat: add Copy Reference context menu for databases and collections (…
tnaum-ms 0b88899
faet: new skill for external PR reviews
tnaum-ms 1a596eb
feat: implement unified Copy Reference command for databases, collect…
tnaum-ms 3a4e6e2
chore: simplified quickpick / wizard code
tnaum-ms 4a1b7f6
Feature: Add selected authentication method and connection user to co…
tnaum-ms 113ee27
feat: add Copy Reference context menu for databases and collections […
tnaum-ms d0754ee
feat: add formatSize utility for formatting byte sizes
tnaum-ms 99ffa65
feat: add database-level tooltip with size on disk
tnaum-ms 9f2fdcc
feat: add collection-level tooltip with type and document count
tnaum-ms 4bc014d
chore: update l10n bundle for tooltip strings
tnaum-ms b4975f4
fix: drop sizeOnDisk from database tooltip, capitalize type badges
tnaum-ms 41a1b57
chore: remove unused formatSize utility
tnaum-ms 0957953
Merge branch 'next' into dev/tnaum/tooltips
tnaum-ms aeb9960
fix: escape hosts and auth label in cluster tooltip markdown
tnaum-ms 9ee1629
fix: resolve unsafe enum comparison lint error in tooltip
tnaum-ms cca994d
Feature: expand tooltips to cluster, database, and collection levels …
tnaum-ms 11990ff
Added functionality for URL decoding of password and suggesting to fi…
682b2de
chore: update l10n bundle after adding URL-encoded password strings
tnaum-ms be40588
feat: implement URL-encoded password handling with user confirmation …
tnaum-ms 0d20987
feat: enhance URL-encoded password handling with user prompts for ret…
tnaum-ms b35727b
feat: add error handling for saving updated credentials and implement…
tnaum-ms e358bd9
Feat: Add URL-encoding detection and retry logic for cluster authenti…
tnaum-ms 63a7e8e
chore: version bump to `0.7.4`
tnaum-ms c312e17
feat: add release notes for v0.7.4 with new features, improvements, a…
tnaum-ms aa7c191
Bump version to 0.7.4 and add release notes (#596)
tnaum-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| --- | ||
| name: review-external-pr | ||
| description: Prepare an external contributor's PR for maintainer review by redirecting it into a dedicated review branch, then merging and creating a new finalization PR targeting next. Use when triaging/reviewing contributor PRs, merging external PRs with maintainer changes, or setting up a review workflow for incoming community contributions. | ||
| --- | ||
|
|
||
| # Review External PR Workflow | ||
|
|
||
| Redirects an external contributor's PR into a `reviews/` staging branch so a maintainer can inspect, add changes, then merge everything into `next` cleanly. | ||
|
|
||
| ## When to Use | ||
|
|
||
| - An external contributor opened a PR targeting `next` and you want to add changes before merging | ||
| - You want to formally review and finalize a community contribution | ||
| - You want the contributor to get proper merge credit while still controlling what lands in `next` | ||
|
|
||
| ## Workflow Steps | ||
|
|
||
| ### 1. Gather PR Info | ||
|
|
||
| ```bash | ||
| gh pr view <PR_NUMBER> --json title,author,headRefName,baseRefName,body | ||
| ``` | ||
|
|
||
| Note the **PR number**, **title**, and **author login** — you'll need them for branch naming and PR descriptions. | ||
|
|
||
| ### 2. Create the Review Branch | ||
|
|
||
| Branch naming format: `reviews/<helpful-name>-original-pr-<number>` | ||
|
|
||
| ```bash | ||
| git fetch origin | ||
| git checkout -b reviews/<helpful-name>-original-pr-<PR_NUMBER> origin/next | ||
| git push origin reviews/<helpful-name>-original-pr-<PR_NUMBER> | ||
| ``` | ||
|
|
||
| Example: `reviews/copy-reference-original-pr-545` | ||
|
|
||
| ### 3. Retarget the Contributor's PR | ||
|
|
||
| > ⚠️ **Known issue**: `gh pr edit --base` may emit a deprecation warning about Projects (classic). This is a cosmetic warning only — the base branch change succeeds regardless. Verify with `gh pr view <PR_NUMBER> --json baseRefName`. | ||
|
|
||
| ```bash | ||
| gh pr edit <PR_NUMBER> --base reviews/<helpful-name>-original-pr-<PR_NUMBER> | ||
| ``` | ||
|
|
||
| Verify: | ||
|
|
||
| ```bash | ||
| gh pr view <PR_NUMBER> --json baseRefName | ||
| ``` | ||
|
|
||
| ### 4. Merge the Contributor's PR | ||
|
|
||
| Once the base is updated and the PR is ready: | ||
|
|
||
| ```bash | ||
| gh pr merge <PR_NUMBER> --squash | ||
| ``` | ||
|
|
||
| Or approve + merge via the GitHub UI to trigger any required status checks. | ||
|
|
||
| ### 5. Create the Finalization PR | ||
|
|
||
| Pull the merged review branch, then open a new PR from it to `next`: | ||
|
|
||
| ```bash | ||
| git checkout reviews/<helpful-name>-original-pr-<PR_NUMBER> | ||
| git pull origin reviews/<helpful-name>-original-pr-<PR_NUMBER> | ||
| ``` | ||
|
|
||
| Create the PR: | ||
|
|
||
| ```bash | ||
| gh pr create \ | ||
| --base next \ | ||
| --head reviews/<helpful-name>-original-pr-<PR_NUMBER> \ | ||
| --title "<original title> [reviewed]" \ | ||
| --body "This PR finalizes the review of the contribution originally submitted by @<author_login> in #<PR_NUMBER>. | ||
|
|
||
| Original PR: <PR_URL>" | ||
| ``` | ||
|
|
||
| ### 6. Comment on the Original PR | ||
|
|
||
| Go back to the contributor's original (now merged) PR and leave a comment linking to the finalization PR: | ||
|
|
||
| ```bash | ||
| gh pr comment <ORIGINAL_PR_NUMBER> \ | ||
| --body "Thank you for the contribution! The review is continuing in #<NEW_PR_NUMBER> where maintainer changes will be finalized before merging to \`next\`." | ||
| ``` | ||
|
|
||
| ## Summary | ||
|
|
||
| | Step | Action | Result | | ||
| | ---- | ------------------------------------------ | ----------------------------------------- | | ||
| | 1 | Gather PR info | Know PR number, title, author | | ||
| | 2 | Create `reviews/...` branch off `next` | Staging branch ready | | ||
| | 3 | Retarget contributor's PR to review branch | Their diff is scoped to review branch | | ||
| | 4 | Merge contributor's PR | Contributor gets merge credit | | ||
| | 5 | Create finalization PR to `next` | Maintainer controls what lands in `next` | | ||
| | 6 | Comment on original PR with link to new PR | Contributor is informed, thread is linked | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry says rich tooltips display storage size, but the current tooltip implementations in this PR don't render any storage-size values (DatabaseItem shows only name + badge; CollectionItem shows document count). Please align this entry with the actual behavior or update the tooltips to include the size data.