Skip to content

[kbookmarks] New port - #52559

Open
Daniele E. Domenichelli (drdanz) wants to merge 1 commit into
microsoft:masterfrom
drdanz:kbookmarks
Open

Daniele E. Domenichelli (drdanz) wants to merge 1 commit into
microsoft:masterfrom
drdanz:kbookmarks

Conversation

@drdanz

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • The packaged project is mature and ready for broad sharing with vcpkg users
    • Has a release at least 6 months old or 6 months of demonstrated public development
    • Is an official component of something else meeting that criteria
    • Some other reason (please explain)
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org/project/kbookmarks/versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new port needs upstream licensing, dependency, and consumer-integration validation before approval.

1 open issue
What changed in this PR

Adds KBookmarks 6.30.0 to vcpkg.

Changes:

  • Adds the build recipe and dependency manifest.
  • Provides an optional translations feature.
  • Registers the port in the version database.

Validation was limited to source review; upstream licensing, dependency requirements, and consumer integration remain unverified.

File Description
versions/​k-/​kbookmarks.json Records the initial port version.
versions/​baseline.json Adds the KBookmarks baseline.
ports/​kbookmarks/​vcpkg.json Declares dependencies and translations support.
ports/​kbookmarks/​portfile.cmake Downloads, builds, and packages KBookmarks.

Review effort: Balanced

Comment thread ports/kbookmarks/vcpkg.json

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants