Add support for query parameters for POST, PATCH, and PUT requests - #375
Open
Juanjo (ajuanjojjj) wants to merge 2 commits into
Open
Add support for query parameters for POST, PATCH, and PUT requests#375Juanjo (ajuanjojjj) wants to merge 2 commits into
Juanjo (ajuanjojjj) wants to merge 2 commits into
Conversation
Juanjo (ajuanjojjj)
force-pushed
the
master
branch
from
July 10, 2024 15:13
1646840 to
2f1fb94
Compare
Author
|
Rebased for 7ad2a7a |
|
Ivan Duplenskikh (@ivanduplenskikh) will this PR be reviewed? |
Author
|
Salih Can Erdal (@scerdal) I dont want to sound overly pessimistic, but the previous PR that this one is based on, #301 , sat there for almost 3 years without a single message from any maintainer. I'd love to be proven wrong, but I wouldn't bet on it getting merged anytime soon :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that query parameters were only supported for GET and DELETE requests.
However, since some APIs support query parameters for the other methods as well, adding support for them could enhance the versatility of the client.
Fixes #257 and has no known breaking changes.