Skip to content

[lookup-by-path] Add toJson()/fromJson() methods#5754

Merged
dmichon-msft merged 5 commits intomainfrom
copilot/enhance-lookup-by-path-json-methods
Apr 8, 2026
Merged

[lookup-by-path] Add toJson()/fromJson() methods#5754
dmichon-msft merged 5 commits intomainfrom
copilot/enhance-lookup-by-path-json-methods

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

  • Add toJson() and fromJson() methods to LookupByPath for serialization/deserialization
  • Build and test (76 tests pass)
  • Create change file for @rushstack/lookup-by-path with minor bump
  • Address PR feedback:
    • Update change file comment to use backtick formatting per iclanton's suggestion
    • Update test describe block to use LookupByPath.prototype.toJson.name pattern per iclanton
    • Add snapshot tests of serialized JSON per iclanton
    • Keep Map (not WeakMap) per dmichon-msft's preference

Copilot AI and others added 3 commits April 6, 2026 23:37
…eserialization

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/3c398d38-9717-42ba-a657-ca2385a2a8f3

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/5d9f37a7-dbe9-4977-b391-4a4d359e0856

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot AI requested a review from dmichon-msft April 7, 2026 23:00
@dmichon-msft dmichon-msft changed the title Use Object.create(null) for dictionary initialization in LookupByPath.toJson() [lookup-by-path] Add toJson()/fromJson() methods Apr 8, 2026
@dmichon-msft dmichon-msft marked this pull request as ready for review April 8, 2026 18:34
…be name, add snapshot tests

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/f33fe415-7fc0-4905-8330-774013ebbe50

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot AI requested a review from dmichon-msft April 8, 2026 21:12
@dmichon-msft dmichon-msft merged commit 9931191 into main Apr 8, 2026
9 checks passed
@dmichon-msft dmichon-msft deleted the copilot/enhance-lookup-by-path-json-methods branch April 8, 2026 23:41
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants