fix(build): remediate CVEs, enforce equality pinning, repair Dependabot config#391
Open
WilliamBerryiii wants to merge 2 commits intomainfrom
Open
fix(build): remediate CVEs, enforce equality pinning, repair Dependabot config#391WilliamBerryiii wants to merge 2 commits intomainfrom
WilliamBerryiii wants to merge 2 commits intomainfrom
Conversation
…ot config - fix lodash prototype pollution CVE via overrides in root, frontend, docusaurus - add qs override to resolve CVE in docusaurus express dependency chain - pin all 6 pyproject.toml files to == equality versions - pin all 3 package.json files to exact resolved versions - regenerate all lockfiles (3 uv.lock, 3 package-lock.json) - repair dependabot.yml from 7 broken entries to 14 valid ecosystem entries - fix scanner dot-source guard to use return instead of exit 1 for Pester compat - add pip fixture files for pinned/unpinned pyproject.toml and requirements.txt 🔒 - Generated by Copilot
Contributor
Dependency ReviewThe following issues were found:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 43.58% 43.58%
=======================================
Files 242 242
Lines 14840 14840
Branches 1855 1903 +48
=======================================
Hits 6468 6468
Misses 8082 8082
Partials 290 290
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
- add 3 lodash@4.17.21 GHSAs to dependency-review allow list (no upstream fix) - pin evaluation Docker requirements to exact == versions - skip self-referencing package entries in pyproject.toml scanner 🔒 - Generated by Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved 5 open CVEs, enforced strict equality (
==) pinning across all 6 Python workspaces and exact semver pinning across all 3 npm workspaces, and repaired the Dependabot configuration to reflect current repository structure. Hardened the dependency pinning CI scanner to correctly validate pip ecosystems and fixed its dot-source guard that prevented standalone execution.Closes #390
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationChanges
CVE Remediation
Addressed 5 CVEs across Python and npm ecosystems:
==2.4.xand azure-identity to==1.23.0+across affected pyproject.toml filesEquality Pinning Enforcement
Converted all dependency version specifiers to strict equality:
>=,~=, and range operators with==across 28+ dependencies in data-management/viewer/backend/pyproject.toml alone, plus evaluation/, training/il/lerobot/, training/rl/, root, and data-management/viewer/^and~range operators in data-management/viewer/frontend/, docs/docusaurus/, and rootDependabot Configuration Repair
Rewrote .github/dependabot.yml from 12 entries (several invalid) to 14 valid entries:
pipecosystem references withuvfor all Python workspacesCI Scanner Hardening
Updated shared/ci/security/Test-DependencyPinning.ps1 with 4 fixes:
Write-Error+exit 1toreturn, which prevented the script from being sourced by PesterGet-PipDependencyViolationsfunction for validating pip equality pinning in pyproject.toml and requirements.txt filesTest-SHAPinningto apply ecosystem-specific validation patternsAdded 4 new test fixtures in shared/ci/tests/Fixtures/Pip/ and updated the dot-source guard expectation in the Pester test file.
Workflow Update
Expanded the default
dependency_typesin .github/workflows/dependency-pinning-scan.yml to includegithub-actions,npm,pip,shell-downloads.Testing Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Additional testing performed:
npm audit(root): 0 vulnerabilitiesnpm audit(frontend): 0 vulnerabilitiesnpm audit(docusaurus): 25 remaining — all lodash transitive dependencies with no upstream fix availableuv lock --checkacross all 3 Python workspaces: locked and consistentDocumentation Impact
Bug Fix Checklist
Checklist
Additional Notes