Repository navigation
Fix QDQ MatMul fusion by validating quantization parameters - #33616
Open
Theodore Cooper (the0cp) wants to merge 2 commits into
Open
Theodore Cooper (the0cp) wants to merge 2 commits into
Theodore Cooper (the0cp) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The kernel-specific checks also restrict shared execution-provider grouping, breaking previously supported QNN quantized MatMul offload.
1 open issue
What changed in this PR
This PR adds quantization-parameter validation to ONNX Runtime’s QDQ MatMul fusion to avoid unsupported QLinearMatMul nodes or incorrect results.
Changes:
- Require scalar or single-element quantization parameters for A and Y.
- Allow B’s per-tensor or supported two-dimensional per-column quantization, skipping fusion otherwise.
- Add five regression tests covering supported and rejected parameter shapes and axes.
| File | Description |
|---|---|
onnxruntime/test/optimizer/qdq_transformer_test.cc |
Adds fusion and fallback tests for MatMul quantization parameters. |
onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_selectors.cc |
Validates parameter shapes and B’s quantization axis before fusion. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fix QDQ MatMul fusion that can produce an unsupported
QLinearMatMulor incorrect results when per-axis quantization parameters are used.The selector now validates that:
A and Y use scalar or single-element quantization parameters.
B uses per-tensor or supported 2D per-column quantization, with a supported axis and shapes.
Unsupported cases fall back to the original
DQ → MatMul → Qpath by skipping fusion, preserving correctness without changing the kernels.fix: #33333