Skip to content

Fix SDL issues #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vladimir Morozov (vmoroz) merged 6 commits into from
Oct 2, 2026
Merged

Fix SDL issues #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d8f232
Fix SDL issues
vmoroz Oct 2, 2026
770a02b
Address Copilot review round 1 in SDL exclusions
vmoroz Oct 2, 2026
b33d93e
Address Copilot review round 2 in SDL exclusions
vmoroz Oct 2, 2026
cd9a8f3
Address Copilot review round 3 in SDL exclusions
vmoroz Oct 2, 2026
7a0a2f6
Fix broken ASO pipeline syntax
vmoroz Oct 2, 2026
79ec90a
Address Copilot review round 4 in SDL exclusions
vmoroz Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .ado/build-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,12 @@ extends:
componentgovernance:
ignoreDirectories: $(Build.SourcesDirectory)\website
eslint:
# This repo does not ship any JavaScript code. All JS/TS files are test
# cases, benchmarks, or internal tools. Exclusions are in .eslintignore
# at the repo root. enableExclusions must be true so the Guardian task
# does not pass --no-ignore to ESLint (which would bypass .eslintignore).
enableExclusions: true
exclusionsFilePath: $(Build.SourcesDirectory)\.eslintignore
Comment thread
vmoroz marked this conversation as resolved.
bandit:
# This repo does not ship any Python code. All .py files are build
# scripts, test utilities, benchmarks, or external tools (LLVM lit).
enabled: false
suppression:
suppressionFile: $(Build.SourcesDirectory)\.ado\guardian\sdl\.gdnsuppress
codeql:
compiled:
enabled: true
Expand Down Expand Up @@ -314,6 +309,8 @@ extends:
displayName: Publish symbols
inputs:
SearchPattern: $(Build.StagingDirectory)\out\pkg-staging\**\*.pdb
# PublishSymbols@2 cannot source-index GitHub repositories.
IndexSources: false
SymbolServerType: TeamServices
UseNetCoreClientTool: true

Expand Down
2,634 changes: 0 additions & 2,634 deletions .ado/guardian/sdl/.gdnsuppress
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions .ado/release-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,12 @@ extends:
os: windows
sdl:
eslint:
# This repo does not ship any JavaScript code. All JS/TS files are
# test cases, benchmarks, or internal tools. Exclusions are in
# .eslintignore at the repo root, so keep exclusions enabled.
enableExclusions: true
exclusionsFilePath: $(Build.SourcesDirectory)\.eslintignore
Comment thread
vmoroz marked this conversation as resolved.
bandit:
# This repo does not ship any Python code. All .py files are build
# scripts, test utilities, benchmarks, or external tools (LLVM lit).
enabled: false
suppression:
suppressionFile: $(Build.SourcesDirectory)\.ado\guardian\sdl\.gdnsuppress

stages:
- stage: nuget_publish
Expand Down
4 changes: 2 additions & 2 deletions .ado/scripts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions API/hermes/cdp/tools/hermes-inspector-msggen/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,12 +2017,12 @@ __metadata:
linkType: hard

"brace-expansion@npm:^1.1.7":
version: 1.1.18
resolution: "brace-expansion@npm:1.1.18"
version: 1.1.21
resolution: "brace-expansion@npm:1.1.21"
dependencies:
balanced-match: "npm:^1.0.0"
concat-map: "npm:0.0.1"
checksum: 10c0/3432c18a9e2ebf94162d4effb62198bd0adea06a9f332b2c0188df5d5e30b1e51ea3c848b6608e47d0b857ebe1ea5b3888ed3326dd3c4f6f9645c94153cf9c14
checksum: 10c0/8f0a68a720f9cb28c2ecaea5cdaf15fafd686d6b6e4e722a81c9d4bd2f68c1fd0619731cac05875d842221eaf4d97d564d329a12eb3c4c22137502fb3c65be8b
languageName: node
linkType: hard

Expand Down
4 changes: 2 additions & 2 deletions benchmarks/widgets/original/es5/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions benchmarks/widgets/single-file/es5/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tools/hcdp/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions tools/hermes-parser/js/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3021,21 +3021,21 @@ __metadata:
linkType: hard

"brace-expansion@npm:^1.1.7":
version: 1.1.18
resolution: "brace-expansion@npm:1.1.18"
version: 1.1.21
resolution: "brace-expansion@npm:1.1.21"
dependencies:
balanced-match: "npm:^1.0.0"
concat-map: "npm:0.0.1"
checksum: 10c0/3432c18a9e2ebf94162d4effb62198bd0adea06a9f332b2c0188df5d5e30b1e51ea3c848b6608e47d0b857ebe1ea5b3888ed3326dd3c4f6f9645c94153cf9c14
checksum: 10c0/8f0a68a720f9cb28c2ecaea5cdaf15fafd686d6b6e4e722a81c9d4bd2f68c1fd0619731cac05875d842221eaf4d97d564d329a12eb3c4c22137502fb3c65be8b
languageName: node
linkType: hard

"brace-expansion@npm:^2.0.1, brace-expansion@npm:^2.0.2":
version: 2.1.4
resolution: "brace-expansion@npm:2.1.4"
version: 2.1.7
resolution: "brace-expansion@npm:2.1.7"
dependencies:
balanced-match: "npm:^1.0.0"
checksum: 10c0/6c0a0e2573eac1dc565b52b1e1bfbeba39bf1830d106ebbc61ff1eaefcf610e9111cd3baa091addd18e33292135c99e019d3184d966389d85dc958fdcdc1449f
checksum: 10c0/17ee4194c85b05cde0a7b7c068eeef664440c027116ef42c3d35c13ebabdc9fd3eaf05c5c8a06dd0ca20ae012d652561d8ac2a699daa5cbee1f0510e5134ab4d
languageName: node
linkType: hard

Expand Down
4 changes: 2 additions & 2 deletions unittests/NodeApi/test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions utils/promise/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ __metadata:
linkType: hard

"brace-expansion@npm:^1.1.7":
version: 1.1.18
resolution: "brace-expansion@npm:1.1.18"
version: 1.1.21
resolution: "brace-expansion@npm:1.1.21"
dependencies:
balanced-match: "npm:^1.0.0"
concat-map: "npm:0.0.1"
checksum: 10c0/3432c18a9e2ebf94162d4effb62198bd0adea06a9f332b2c0188df5d5e30b1e51ea3c848b6608e47d0b857ebe1ea5b3888ed3326dd3c4f6f9645c94153cf9c14
checksum: 10c0/8f0a68a720f9cb28c2ecaea5cdaf15fafd686d6b6e4e722a81c9d4bd2f68c1fd0619731cac05875d842221eaf4d97d564d329a12eb3c4c22137502fb3c65be8b
languageName: node
linkType: hard

Expand Down
6 changes: 3 additions & 3 deletions utils/scripts/hermes/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ __metadata:
linkType: hard

"brace-expansion@npm:^1.1.7":
version: 1.1.18
resolution: "brace-expansion@npm:1.1.18"
version: 1.1.21
resolution: "brace-expansion@npm:1.1.21"
dependencies:
balanced-match: "npm:^1.0.0"
concat-map: "npm:0.0.1"
checksum: 10c0/3432c18a9e2ebf94162d4effb62198bd0adea06a9f332b2c0188df5d5e30b1e51ea3c848b6608e47d0b857ebe1ea5b3888ed3326dd3c4f6f9645c94153cf9c14
checksum: 10c0/8f0a68a720f9cb28c2ecaea5cdaf15fafd686d6b6e4e722a81c9d4bd2f68c1fd0619731cac05875d842221eaf4d97d564d329a12eb3c4c22137502fb3c65be8b
languageName: node
linkType: hard

Expand Down
Loading