[shimV2] order container teardown so the UVM can reap bundle dirs#2737
Merged
Conversation
rawahars
force-pushed
the
v2_bug_delete_task
branch
from
3648f26 to
090ed43
Compare
jterry75
reviewed
May 13, 2026
jterry75
reviewed
May 13, 2026
jterry75
approved these changes
May 13, 2026
jiechen0826
approved these changes
May 13, 2026
* Deleting an LCOW container no longer leaves the bundle/scratch parent pod dir (/run/gcs/pods/<podID>) inside the UVM. * KillProcess fans the signal out to every exec when the caller asks for "all" or passes an empty execID, matching the "kill the whole container" path used by delete. Theme: re-sequence host- and guest-side teardown around DeleteContainerState. internal/controller/linuxcontainer: - Relocate the DeleteContainerState GCS RPC from closeContainer() to the tail of releaseResources(), so it runs after the combined-layer overlay, SCSI mounts, and VPCI devices are released. Issuing it earlier left the overlay mounted over the bundle root, which blocked the GCS from removing it. - Gate the RPC behind a new isContainerStateDeleted flag. - closeContainer() now only closes the container handle and terminatedCh. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
v2_bug_delete_task
branch
from
090ed43 to
d051c78
Compare
jiechen0826
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Theme: re-sequence host- and guest-side teardown around DeleteContainerState.
internal/controller/linuxcontainer: