Repository navigation
ci: add Darwin arm64 nocgo coverage - #2626
Merged
George Adams (gdams) merged 1 commit intoOct 22, 2026
Merged
Conversation
Add the missing Darwin arm64 nocgo inner-loop builder alongside the existing amd64 check. Reuse the native arm64 pool and existing build/test configuration with CGO_ENABLED=0 and system crypto enabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single matrix addition uses established configuration and execution paths without introducing new logic or unresolved issues.
No open issues 🎉
What changed in this PR
Adds Darwin arm64 nocgo coverage to the inner-loop CI matrix, matching the existing Darwin amd64 check.
Changes:
- Adds a Darwin arm64 build/test configuration with CGO disabled and system crypto enabled.
- Reuses the existing native arm64 pool and test/retry infrastructure.
| File | Description |
|---|---|
eng/pipeline/stages/go-builder-matrix-stages.yml |
Adds the Darwin arm64 nocgo builder entry. |
Review effort: Balanced
Quim Muntal (qmuntal)
approved these changes
Oct 22, 2026
George Adams (gdams)
enabled auto-merge (squash)
October 22, 2026 08:27
This was referenced Oct 22, 2026
George Adams (gdams)
added a commit
that referenced
this pull request
Oct 22, 2026
Add the missing Darwin arm64 nocgo inner-loop builder alongside the existing amd64 check. Reuse the native arm64 pool and existing build/test configuration with CGO_ENABLED=0 and system crypto enabled. (cherry picked from commit f8d6077) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
George Adams (gdams)
added a commit
that referenced
this pull request
Oct 22, 2026
Backport the missing Darwin arm64 nocgo inner-loop builder. Preserve Go 1.26's explicit systemcrypto experiment so the new job tests the native crypto backend with CGO_ENABLED=0. (cherry picked from commit f8d6077; adapted for Go 1.26) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nocgoinner-loop builder, matching the existing Darwin amd64 check.CGO_ENABLED=0and system crypto enabled on the existing native arm64 hosted pool.Validation
go -C eng/_util test -mod=readonly -count=1 -v ./cmd/pipelineymlgenpassed.nocgobuilder for each of amd64 and arm64, with nonosystemcryptooverride.git diff --checkpassed.The complete Darwin arm64 nocgo build/test job will be validated by CI.