Skip to content

Remove fragile pipeline yml parse tests - #2622

Merged
Davis Goodin (dagood) merged 2 commits into
microsoft/mainfrom
dev/dagood/remove-fragile-yml-parse-tests
Oct 21, 2026
Merged

Davis Goodin (dagood) merged 2 commits into
microsoft/mainfrom
dev/dagood/remove-fragile-yml-parse-tests

Conversation

@dagood

Copy link
Copy Markdown
Member

It seems these PRs didn't have a merge conflict, but did have a logical conflict. When both were merged, tests in main started to fail:

The pipeline-yml-parsing tests seem too fragile to be worthwhile and I don't think they would be worth the maintenance effort long term.

#2621 failed with:

--- FAIL: TestDarwinFreshAgentRetry (0.00s)
    run_stage_test.go:108: displayName = &{8 0 !!str ${{ parameters.builder.os }}-${{ parameters.builder.arch }} ${{ parameters.builder.hostParens}} ${{ parameters.builder.config }} ${{ parameters.builder.distroParens}} ${{ parameters.builder.experimentBrackets }} ${{ parameters.builder.nosystemcryptoBrackets }} ${{ parameters.builder.fipsAcronym }} (test retry)  <nil> []    313 24 <nil>}, want "${{ iif(eq(parameters.builder.broken, true), '(BROKEN) ', '') }}${{ parameters.builder.os }}-${{ parameters.builder.arch }} ${{ parameters.builder.hostParens}} ${{ parameters.builder.config }} ${{ parameters.builder.distroParens}} ${{ parameters.builder.experimentBrackets }} ${{ parameters.builder.nosystemcryptoBrackets }} ${{ parameters.builder.fipsAcronym }} (test retry)"
FAIL
FAIL	github.com/microsoft/go/_util/cmd/pipelineymlgen	5.664s

@dagood
Davis Goodin (dagood) requested a review from a team as a code owner October 21, 2026 17:02
Copilot AI balanced review requested due to automatic review settings October 21, 2026 17:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Four unused imports prevent the remaining test package from compiling.

1 open issue
What changed in this PR

Removes fragile pipeline YAML tests following conflicting changes to Darwin retries and artifact publishing.

Changes:

  • Deletes Darwin retry configuration, command, and archive tests.
  • Removes artifact retry-safety checks while retaining generator reproducibility coverage.
File Description
eng/​_util/​cmd/​pipelineymlgen/​run_stage_test.go Deletes Darwin retry tests and YAML helpers.
eng/​_util/​cmd/​pipelineymlgen/​pipelineymlgen_test.go Removes artifact-safety tests.

Review effort: Balanced

Comment thread eng/_util/cmd/pipelineymlgen/pipelineymlgen_test.go
@dagood
Davis Goodin (dagood) enabled auto-merge (squash) October 21, 2026 17:22
@dagood
Davis Goodin (dagood) merged commit 3d71e95 into microsoft/main Oct 21, 2026
61 checks passed
@dagood
Davis Goodin (dagood) deleted the dev/dagood/remove-fragile-yml-parse-tests branch October 21, 2026 19:21
@qmuntal

Quim Muntal (qmuntal) commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants