Repository navigation
Remove fragile pipeline yml parse tests - #2622
Merged
Davis Goodin (dagood) merged 2 commits intoOct 21, 2026
Merged
Davis Goodin (dagood) merged 2 commits into
Davis Goodin (dagood) merged 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
George Adams (gdams)
approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Four unused imports prevent the remaining test package from compiling.
1 open issue
What changed in this PR
Removes fragile pipeline YAML tests following conflicting changes to Darwin retries and artifact publishing.
Changes:
- Deletes Darwin retry configuration, command, and archive tests.
- Removes artifact retry-safety checks while retaining generator reproducibility coverage.
| File | Description |
|---|---|
| eng/_util/cmd/pipelineymlgen/run_stage_test.go | Deletes Darwin retry tests and YAML helpers. |
| eng/_util/cmd/pipelineymlgen/pipelineymlgen_test.go | Removes artifact-safety tests. |
Review effort: Balanced
Davis Goodin (dagood)
enabled auto-merge (squash)
October 21, 2026 17:22
Davis Goodin (dagood)
deleted the
dev/dagood/remove-fragile-yml-parse-tests
branch
October 21, 2026 19:21
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It seems these PRs didn't have a merge conflict, but did have a logical conflict. When both were merged, tests in main started to fail:
The pipeline-yml-parsing tests seem too fragile to be worthwhile and I don't think they would be worth the maintenance effort long term.
#2621 failed with: