Yield instead of Task.Delay when AOF BulkConsume throttle is zero#1940
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TsavoriteLogScanIterator.BulkConsumeAllAsync to avoid a no-op Task.Delay(0) loop when throttleMs == 0, and tightens encapsulation by making TryBulkConsumeNext private.
Changes:
- Replace
await Task.Delay(0, token)-style waiting with aTask.Yield()path whenthrottleMs == 0. - Keep
Task.Delay(throttleMs, token)for non-zero throttling. - Change
TryBulkConsumeNextvisibility frompublictoprivate.
badrishc
approved these changes
Jul 16, 2026
badrishc
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid blocking for a full
throttleMsinterval inBulkConsumewhen the throttle duration is zero. WhenthrottleMs == 0, yield the thread (await Task.Yield()) instead ofawait Task.Delay(0)while waiting for the next record.Also makes
TryBulkConsumeNextprivate.Closes #1939